Skip to content

Remove call to addError, as it isn't defined anywhere #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove call to addError, as it isn't defined anywhere #7

wants to merge 1 commit into from

Conversation

cainux
Copy link

@cainux cainux commented Mar 17, 2021

I'm coming across schema which look something like:

protocol x {
  @namespace("foo")
  fixed Code(3);

  record Currency {
    @java-class("java.math.BigDecimal") string amount;
    foo.Code code;
  }
}

So RecordConverter ends up calling addError before returning "any", which doesn't seem to have a body defined anywhere, resulting in an error.

This PR is a small change to sidestep the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cainux